Skip to content

test: isolate LSP timeout recovery coverage - #300

Merged
jcarver989 merged 1 commit into
mainfrom
fix/lsp-workspace-search-recovery
Jul 28, 2026
Merged

test: isolate LSP timeout recovery coverage#300
jcarver989 merged 1 commit into
mainfrom
fix/lsp-workspace-search-recovery

Conversation

@jcarver989

@jcarver989 jcarver989 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an owned in-process LSP daemon fixture with explicit request timeout configuration
  • guarantee graceful daemon and language-server cleanup, including test failure paths
  • centralize fake language-server configuration for daemon and MCP tests
  • cover MCP workspace-search timeout propagation and recovery through the public tool API

Why

Passing timeout configuration through CodingMcp, LspRegistry, and LspClient only worked when that client happened to launch the daemon. The test now owns daemon configuration and lifecycle directly, avoiding race-dependent production APIs and leaked test processes.

Validation

  • just fmt
  • just lint
  • just test
  • focused workspace-search recovery e2e

@jcarver989
test: isolate LSP timeout recovery coverage
5b731b4 
Run the recovery daemon with explicit test-owned configuration and deterministic shutdown so timeout tests do not leak processes or expand production APIs.
@jcarver989
jcarver989 enabled auto-merge (squash) July 28, 2026 18:54
@jcarver989
jcarver989 merged commit 7a9494f into main Jul 28, 2026
13 checks passed
@jcarver989
jcarver989 deleted the fix/lsp-workspace-search-recovery branch July 28, 2026 19:01
@contextbridge-pr-automation contextbridge-pr-automation Bot mentioned this pull request Jul 28, 2026
Merged
jcarver989 pushed a commit that referenced this pull request Jul 28, 2026
@contextbridge-pr-automation
chore: release (#299)
6ce6823 
## 🤖 New release

* `aether-llm-codegen`: 0.2.17 -> 0.2.18
* `aether-lspd`: 0.1.27 -> 0.1.28
* `aether-project`: 0.5.27 -> 0.5.28
* `aether-mcp-servers`: 0.4.32 -> 0.4.33
* `aether-wisp`: 0.4.36 -> 0.4.37
* `aether-agent-cli`: 0.7.29 -> 0.7.30
* `aether-schemas`: 0.1.13 -> 0.1.14
* `aether-llm`: 0.7.24 -> 0.7.25
* `aether-mcp-utils`: 0.5.29 -> 0.5.30
* `aether-acp-utils`: 0.3.35 -> 0.3.36
* `aether-agent-core`: 0.6.26 -> 0.6.27
* `aether-telemetry`: 0.1.7 -> 0.1.8
* `aether-evals`: 0.2.18 -> 0.2.19

<details><summary><i><b>Changelog</b></i></summary><p>

## `aether-llm-codegen`

<blockquote>

##
[0.2.18](aether-llm-codegen-v0.2.17...aether-llm-codegen-v0.2.18)
- 2026-07-28

### Other

- *(deps)* bump prettyplease from 0.2.37 to 0.3.0
([#286](#286))
</blockquote>

## `aether-lspd`

<blockquote>

##
[0.1.28](aether-lspd-v0.1.27...aether-lspd-v0.1.28)
- 2026-07-28

### Other

- isolate LSP timeout recovery coverage
([#300](#300))
</blockquote>

## `aether-project`

<blockquote>

##
[0.5.28](aether-project-v0.5.27...aether-project-v0.5.28)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-mcp-servers`

<blockquote>

##
[0.4.33](aether-mcp-servers-v0.4.32...aether-mcp-servers-v0.4.33)
- 2026-07-28

### Other

- isolate LSP timeout recovery coverage
([#300](#300))
</blockquote>

## `aether-wisp`

<blockquote>

##
[0.4.37](aether-wisp-v0.4.36...aether-wisp-v0.4.37)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-agent-cli`

<blockquote>

##
[0.7.30](aether-agent-cli-v0.7.29...aether-agent-cli-v0.7.30)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-schemas`

<blockquote>

##
[0.1.14](aether-schemas-v0.1.13...aether-schemas-v0.1.14)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-llm`

<blockquote>

##
[0.7.25](aether-llm-v0.7.24...aether-llm-v0.7.25)
- 2026-07-28

### Other

- updated the following local packages: aether-llm-codegen
</blockquote>

## `aether-mcp-utils`

<blockquote>

##
[0.5.30](aether-mcp-utils-v0.5.29...aether-mcp-utils-v0.5.30)
- 2026-07-28

### Other

- updated the following local packages: aether-llm
</blockquote>

## `aether-acp-utils`

<blockquote>

##
[0.3.36](aether-acp-utils-v0.3.35...aether-acp-utils-v0.3.36)
- 2026-07-28

### Other

- updated the following local packages: aether-mcp-utils
</blockquote>

## `aether-agent-core`

<blockquote>

##
[0.6.27](aether-agent-core-v0.6.26...aether-agent-core-v0.6.27)
- 2026-07-28

### Other

- updated the following local packages: aether-llm, aether-mcp-utils,
aether-acp-utils
</blockquote>

## `aether-telemetry`

<blockquote>

##
[0.1.8](aether-telemetry-v0.1.7...aether-telemetry-v0.1.8)
- 2026-07-28

### Other

- updated the following local packages: aether-llm, aether-agent-core,
aether-agent-core
</blockquote>

## `aether-evals`

<blockquote>

##
[0.2.19](aether-evals-v0.2.18...aether-evals-v0.2.19)
- 2026-07-28

### Other

- updated the following local packages: aether-project, aether-llm,
aether-agent-core
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: contextbridge-pr-automation[bot] <259134118+contextbridge-pr-automation[bot]@users.noreply.github.com>
@contextbridge-pr-automation contextbridge-pr-automation Bot mentioned this pull request Jul 28, 2026
Merged
jcarver989 added a commit that referenced this pull request Jul 28, 2026
@contextbridge-pr-automation @jcarver989
chore: release (#302)
d7986b6 
## 🤖 New release

* `aether-llm-codegen`: 0.2.17 -> 0.2.18
* `aether-llm`: 0.7.24 -> 0.7.25
* `aether-agent-core`: 0.6.26 -> 0.6.27
* `aether-lspd`: 0.1.27 -> 0.1.28
* `aether-project`: 0.5.27 -> 0.5.28
* `aether-telemetry`: 0.1.7 -> 0.1.8
* `aether-mcp-servers`: 0.4.32 -> 0.4.33
* `aether-wisp`: 0.4.36 -> 0.4.37
* `aether-agent-cli`: 0.7.29 -> 0.7.30
* `aether-schemas`: 0.1.13 -> 0.1.14
* `aether-mcp-utils`: 0.5.29 -> 0.5.30
* `aether-acp-utils`: 0.3.35 -> 0.3.36
* `aether-evals`: 0.2.18 -> 0.2.19

<details><summary><i><b>Changelog</b></i></summary><p>

## `aether-llm-codegen`

<blockquote>

##
[0.2.18](aether-llm-codegen-v0.2.17...aether-llm-codegen-v0.2.18)
- 2026-07-28

### Fixed

- *(aether-telemetry)* Include reasoning tokens and pricing information
([#301](#301))

### Other

- *(deps)* bump prettyplease from 0.2.37 to 0.3.0
([#286](#286))
</blockquote>

## `aether-llm`

<blockquote>

##
[0.7.25](aether-llm-v0.7.24...aether-llm-v0.7.25)
- 2026-07-28

### Fixed

- *(aether-telemetry)* Include reasoning tokens and pricing information
([#301](#301))
</blockquote>

## `aether-agent-core`

<blockquote>

##
[0.6.27](aether-agent-core-v0.6.26...aether-agent-core-v0.6.27)
- 2026-07-28

### Fixed

- *(aether-telemetry)* Include reasoning tokens and pricing information
([#301](#301))
</blockquote>

## `aether-lspd`

<blockquote>

##
[0.1.28](aether-lspd-v0.1.27...aether-lspd-v0.1.28)
- 2026-07-28

### Other

- isolate LSP timeout recovery coverage
([#300](#300))
</blockquote>

## `aether-project`

<blockquote>

##
[0.5.28](aether-project-v0.5.27...aether-project-v0.5.28)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-telemetry`

<blockquote>

##
[0.1.8](aether-telemetry-v0.1.7...aether-telemetry-v0.1.8)
- 2026-07-28

### Fixed

- *(aether-telemetry)* Include reasoning tokens and pricing information
([#301](#301))
</blockquote>

## `aether-mcp-servers`

<blockquote>

##
[0.4.33](aether-mcp-servers-v0.4.32...aether-mcp-servers-v0.4.33)
- 2026-07-28

### Other

- isolate LSP timeout recovery coverage
([#300](#300))
</blockquote>

## `aether-wisp`

<blockquote>

##
[0.4.37](aether-wisp-v0.4.36...aether-wisp-v0.4.37)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-agent-cli`

<blockquote>

##
[0.7.30](aether-agent-cli-v0.7.29...aether-agent-cli-v0.7.30)
- 2026-07-28

### Fixed

- *(aether-telemetry)* Include reasoning tokens and pricing information
([#301](#301))
</blockquote>

## `aether-schemas`

<blockquote>

##
[0.1.14](aether-schemas-v0.1.13...aether-schemas-v0.1.14)
- 2026-07-28

### Other

- update Cargo.lock dependencies
</blockquote>

## `aether-mcp-utils`

<blockquote>

##
[0.5.30](aether-mcp-utils-v0.5.29...aether-mcp-utils-v0.5.30)
- 2026-07-28

### Other

- updated the following local packages: aether-llm
</blockquote>

## `aether-acp-utils`

<blockquote>

##
[0.3.36](aether-acp-utils-v0.3.35...aether-acp-utils-v0.3.36)
- 2026-07-28

### Other

- updated the following local packages: aether-mcp-utils
</blockquote>

## `aether-evals`

<blockquote>

##
[0.2.19](aether-evals-v0.2.18...aether-evals-v0.2.19)
- 2026-07-28

### Other

- updated the following local packages: aether-llm, aether-agent-core,
aether-project
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: contextbridge-pr-automation[bot] <259134118+contextbridge-pr-automation[bot]@users.noreply.github.com>
Co-authored-by: Joshua Carver <jcarver989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcarver989